Added Unit tests - #15
Merged
Merged
Conversation
| static async executePowerShellCommand(command: string, options: any = {}) { | ||
| await exec.exec(`"${PowerShellToolRunner.psPath}" -Command "${command}"`, [], options); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
We don't need this anymore?
Contributor
Author
There was a problem hiding this comment.
no, we are using executePowerShellScriptBlock instead of executePowerShellCommand,hence removed unused function
| @@ -0,0 +1,7 @@ | |||
| // babel.config.js | |||
Contributor
There was a problem hiding this comment.
Why do we need this file?
Contributor
Author
There was a problem hiding this comment.
i am using typescript to write tests. please refer https://jestjs.io/docs/en/getting-started#using-typescript
| "license": "MIT", | ||
| "devDependencies": { | ||
| "@babel/core": "^7.9.0", | ||
| "@babel/preset-env": "^7.9.0", |
Contributor
There was a problem hiding this comment.
Are you using babel ?
Contributor
Author
There was a problem hiding this comment.
Yes, followed setup as per jest docs - https://jestjs.io/docs/en/getting-started#using-typescript
Member
|
Add workflow for CI |
Ashish Ranjan (asranja)
approved these changes
Apr 8, 2020
aksm-ms
added a commit
to aksm-ms/login
that referenced
this pull request
May 4, 2020
Changes in loginAzurePowerShell.ts using latest version Added getlatestazmodule version changes in runner info code refactor changes in loginAzurePowerShell code refactor Code refactor Code refactor added review comments changes in scriptbuilder changes in setmodulepath added paths in tsconfig.json Revert "added paths in tsconfig.json" This reverts commit cb2f417. changes in action.yml changes in main added review comments Added changes for review comments Modified description in action.yml Added telemetry info Code refactor added review comments added review comments removed tslint from package.json added log in ServicePrincipalLogin added boolean for error log Added Unit tests (Azure#15) * Added unit tests for Azure PowerShell * Added unit tests * changes in utils * removed babel * changed variable name of enable-PSSession * refactor * added ci.yml * changes in utils test making login calls silent (Azure#19) Co-authored-by: Deepak Sattiraju <desattir@microsoft.com> update utils test (Azure#16) * update utils test * update utils test * update serviceprincipallogin test
aksm-ms
added a commit
to aksm-ms/login
that referenced
this pull request
May 4, 2020
Changes in loginAzurePowerShell.ts using latest version Added getlatestazmodule version changes in runner info code refactor changes in loginAzurePowerShell code refactor Code refactor Code refactor added review comments changes in scriptbuilder changes in setmodulepath added paths in tsconfig.json Revert "added paths in tsconfig.json" This reverts commit cb2f417. changes in action.yml changes in main added review comments Added changes for review comments Modified description in action.yml Added telemetry info Code refactor added review comments added review comments removed tslint from package.json added log in ServicePrincipalLogin added boolean for error log Added Unit tests (Azure#15) * Added unit tests for Azure PowerShell * Added unit tests * changes in utils * removed babel * changed variable name of enable-PSSession * refactor * added ci.yml * changes in utils test making login calls silent (Azure#19) Co-authored-by: Deepak Sattiraju <desattir@microsoft.com> update utils test (Azure#16) * update utils test * update utils test * update serviceprincipallogin test
aksm-ms
added a commit
to aksm-ms/login
that referenced
this pull request
May 4, 2020
Changes in loginAzurePowerShell.ts using latest version Added getlatestazmodule version changes in runner info code refactor changes in loginAzurePowerShell code refactor Code refactor Code refactor added review comments changes in scriptbuilder changes in setmodulepath added paths in tsconfig.json Revert "added paths in tsconfig.json" This reverts commit cb2f417. changes in action.yml changes in main added review comments Added changes for review comments Modified description in action.yml Added telemetry info Code refactor added review comments added review comments removed tslint from package.json added log in ServicePrincipalLogin added boolean for error log Added Unit tests (Azure#15) * Added unit tests for Azure PowerShell * Added unit tests * changes in utils * removed babel * changed variable name of enable-PSSession * refactor * added ci.yml * changes in utils test making login calls silent (Azure#19) Co-authored-by: Deepak Sattiraju <desattir@microsoft.com> update utils test (Azure#16) * update utils test * update utils test * update serviceprincipallogin test
aksm-ms
added a commit
that referenced
this pull request
May 6, 2020
Changes in loginAzurePowerShell.ts using latest version Added getlatestazmodule version changes in runner info code refactor changes in loginAzurePowerShell code refactor Code refactor Code refactor added review comments changes in scriptbuilder changes in setmodulepath added paths in tsconfig.json Revert "added paths in tsconfig.json" This reverts commit cb2f417. changes in action.yml changes in main added review comments Added changes for review comments Modified description in action.yml Added telemetry info Code refactor added review comments added review comments removed tslint from package.json added log in ServicePrincipalLogin added boolean for error log Added Unit tests (#15) * Added unit tests for Azure PowerShell * Added unit tests * changes in utils * removed babel * changed variable name of enable-PSSession * refactor * added ci.yml * changes in utils test
aksm-ms
added a commit
that referenced
this pull request
May 6, 2020
* Initial commit * updating package version * adding secret info link in logs * adding user-agent * Update README.md * Added changes for azure powershell login Changes in loginAzurePowerShell.ts using latest version Added getlatestazmodule version changes in runner info code refactor changes in loginAzurePowerShell code refactor Code refactor Code refactor added review comments changes in scriptbuilder changes in setmodulepath added paths in tsconfig.json Revert "added paths in tsconfig.json" This reverts commit cb2f417. changes in action.yml changes in main added review comments Added changes for review comments Modified description in action.yml Added telemetry info Code refactor added review comments added review comments removed tslint from package.json added log in ServicePrincipalLogin added boolean for error log Added Unit tests (#15) * Added unit tests for Azure PowerShell * Added unit tests * changes in utils * removed babel * changed variable name of enable-PSSession * refactor * added ci.yml * changes in utils test making login calls silent (#19) Co-authored-by: Deepak Sattiraju <desattir@microsoft.com> update utils test (#16) * update utils test * update utils test * update serviceprincipallogin test Co-authored-by: Microsoft GitHub User <msftgits@microsoft.com> Co-authored-by: Sumiran Aggarwal <suaggar@microsoft.com> Co-authored-by: UshaN <ushan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sumiran Aggarwal (@SumiranAgg) Arjun Gupta (@arjgupta) please review